Allow accessing external environments in Delta Lake query runner#17202
Merged
Conversation
ebyhr
added
the
no-release-notes
krvikash
reviewed
Apr 26, 2023
ebyhr
force-pushed
the
ebi/delta-external-runner
branch
2 times, most recently
from
9fcc626 to
22000d0
Compare
krvikash
approved these changes
Apr 26, 2023
findinpath
reviewed
Apr 26, 2023
This allows accessing product test environment with VM options. Also, rename to DeltaLakeExternalQueryRunnerMain which is similar to ElasticsearchExternalQueryRunner.
ebyhr
force-pushed
the
ebi/delta-external-runner
branch
from
22000d0 to
9d37af9
Compare
findinpath
approved these changes
Apr 26, 2023
Member
I use trino/testing/trino-server-dev/etc/catalog/hive.properties Lines 10 to 11 in 022a266 |
Member
Author
|
I don't want to wait for slow |
Member
agreed. that's why i also have a separate profile, containing only the catalogs i work with |
findepi
approved these changes
Apr 26, 2023
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
i wouldn't want this (see conversation), but whatever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The main purpose is quickly accessing product test environments using the new
DeltaLakeExternalQueryRunnerMain.Release notes
(x) This is not user-visible or docs only and no release notes are required.